Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new functionalities #109

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding new functionalities #109

wants to merge 2 commits into from

Conversation

gilador
Copy link

@gilador gilador commented Jul 31, 2019

added in this commit:
hide()
unhide()
isInit()

@gilador
Adding new functionalities
5b2fdd6 
added in this commit:
hide()
unhide()
isInit()
@koenpunt
Copy link
Collaborator

koenpunt commented Aug 4, 2019

Thank you for your contribution. What would be a use case for this new functionality?

@gilador
Copy link
Author

gilador commented Aug 4, 2019 via email

@gilador gilador requested a review from koenpunt February 16, 2020 09:20
@koenpunt
Copy link
Collaborator

koenpunt commented Apr 6, 2020

I don't feel much for adding the functionality of hiding the view, since it's a too specific use case, and some would even call it a hack.

And for the isInit method, wouldn't it be more efficient to keep track of that in the JS code of where you're consuming this library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koenpunt koenpunt Awaiting requested review from koenpunt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gilador @koenpunt @GutteApps